[libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix mis-aligned comment

[Hirokazu Honda]

Hi Umang, thank you for reviewing.

On Wed, May 26, 2021 at 10:40 PM Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Hi Umang,
>
> Thank you for the patch.
>
> On Wed, May 26, 2021 at 06:40:24PM +0530, Umang Jain wrote:
> > Fixes: 2fac95b400b7 ("libcamera: pipeline: ipu3: Ensure that
> IPU3Frames::info is not used after delete")
> > Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
>
Reviewed-by: Hirokazu Honda <hiroh at chromium.org>


> > ---
> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp
> b/src/libcamera/pipeline/ipu3/ipu3.cpp
> > index 25203256..750880ed 100644
> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> > @@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer
> *buffer)
> >               info->metadataProcessed = true;
> >
> >               /*
> > -             * tryComplete() will delete info if it completes the
> IPU3Frame.
> > -             * In that event, we must have obtained the Request before
> hand.
> > -             */
> > +              * tryComplete() will delete info if it completes the
> IPU3Frame.
> > +              * In that event, we must have obtained the Request before
> hand.
> > +              */
> >               Request *request = info->request;
> >
> >               if (frameInfos_.tryComplete(info))
>
> --
> Regards,
>
> Laurent Pinchart
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20210526/1576787d/attachment.htm>