[libcamera-devel] [PATCH] libcamera: framebuffer: Fix iscontiguous log message

Jacopo Mondi jacopo at jmondi.org
Thu Nov 4 17:09:22 CET 2021


Hi

On Thu, Nov 04, 2021 at 11:13:47AM +0000, Kieran Bingham wrote:
> The isContiguous debug message is inverted.
> Correct the logic.
>
> Reported-by: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

> ---
>  src/libcamera/framebuffer.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp
> index d44a98babd05..337ea1155a38 100644
> --- a/src/libcamera/framebuffer.cpp
> +++ b/src/libcamera/framebuffer.cpp
> @@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)
>  	}
>
>  	LOG(Buffer, Debug)
> -		<< "Buffer is " << (isContiguous ? "not " : "") << "contiguous";
> +		<< "Buffer is " << (isContiguous ? "" : "not ") << "contiguous";
>
>  	_d()->isContiguous_ = isContiguous;
>  }
> --
> 2.30.2
>


More information about the libcamera-devel mailing list