[libcamera-devel] [PATCH] libcamera: framebuffer: Fix iscontiguous log message

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Nov 4 17:14:26 CET 2021


Hi Kieran and Roman !

On 04/11/2021 12:13, Kieran Bingham wrote:
> The isContiguous debug message is inverted.
> Correct the logic.
> 
> Reported-by: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Thanks a lot !
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> ---
>   src/libcamera/framebuffer.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp
> index d44a98babd05..337ea1155a38 100644
> --- a/src/libcamera/framebuffer.cpp
> +++ b/src/libcamera/framebuffer.cpp
> @@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)
>   	}
>   
>   	LOG(Buffer, Debug)
> -		<< "Buffer is " << (isContiguous ? "not " : "") << "contiguous";
> +		<< "Buffer is " << (isContiguous ? "" : "not ") << "contiguous";
>   
>   	_d()->isContiguous_ = isContiguous;
>   }
> 


More information about the libcamera-devel mailing list