[libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Add const qualifer in isRaw()

[Laurent Pinchart]

Hi Naush,

Thank you for the patch.

On Wed, Nov 10, 2021 at 10:08:00AM +0000, Naushir Patuck wrote:
> This function does not modify the pixFmt parameter, so use a const qualifier.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 5e1f227398a9..11d3c2b120dd 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,
>  	return deviceFormat;
>  }
>  
> -bool isRaw(PixelFormat &pixFmt)
> +bool isRaw(const PixelFormat &pixFmt)

You could even pass the pixel format by value.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  {
>  	/*
>  	 * The isRaw test might be redundant right now the pipeline handler only

-- 
Regards,

Laurent Pinchart