[libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove unused member variables

[Naushir Patuck]

Hi Laurent,

Thank you for your feedback.

On Fri, 19 Nov 2021 at 12:50, Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> Hi Naush,
>
> Thank you for the patch.
>
> On Fri, Nov 19, 2021 at 11:09:55AM +0000, Naushir Patuck wrote:
> > Remove unused member variables from class PipelineHandlerRPi.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > index 8ed2ebcaafe7..d47306bdfec9 100644
> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > @@ -317,9 +317,6 @@ private:
> >       int prepareBuffers(Camera *camera);
> >       void freeBuffers(Camera *camera);
> >       void mapBuffers(Camera *camera, const RPi::BufferMap &buffers,
> unsigned int mask);
> > -
> > -     MediaDevice *unicam_;
> > -     MediaDevice *isp_;
>
> I'd squash this with patch 2/3, as that's where you remove usage of
> those two member variables.
>

Ack, I'll fix this in the next version.

Naush



> >  };
> >
> >  RPiCameraConfiguration::RPiCameraConfiguration(const RPiCameraData
> *data)
> > @@ -510,7 +507,7 @@ CameraConfiguration::Status
> RPiCameraConfiguration::validate()
> >  }
> >
> >  PipelineHandlerRPi::PipelineHandlerRPi(CameraManager *manager)
> > -     : PipelineHandler(manager), unicam_(nullptr), isp_(nullptr)
> > +     : PipelineHandler(manager)
> >  {
> >  }
> >
>
> --
> Regards,
>
> Laurent Pinchart
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20211119/bec87d3f/attachment.htm>