[libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a test candidate

[Laurent Pinchart]

On Tue, Sep 14, 2021 at 01:33:50PM +0900, paul.elder at ideasonboard.com wrote:
> On Tue, Sep 14, 2021 at 04:31:29AM +0300, Laurent Pinchart wrote:
> > Hi Paul,
> > 
> > Thank you for the patch.
> 
> ...and? :p

What ? I wanted to thank you, did you expect more ? So greedy... ;-)

OK, if you insist,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > On Tue, Sep 14, 2021 at 10:04:13AM +0900, Paul Elder wrote:
> > > As the vimc scaler prevents us from passing v4l2-compliance, skip it
> > > until the fix has been merged. Instead of removing it from the
> > > supported_pipelines list, add an extra check, since we will have the
> > > same construct later when we check for the kernel version.
> > > 
> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > > ---
> > >  test/v4l2_compat/v4l2_compat_test.py | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py
> > > index ae892ced..6d304b6c 100755
> > > --- a/test/v4l2_compat/v4l2_compat_test.py
> > > +++ b/test/v4l2_compat/v4l2_compat_test.py
> > > @@ -134,6 +134,10 @@ def main(argv):
> > >          if driver not in supported_pipelines:
> > >              continue
> > >  
> > > +        # TODO: Add kernel version check
> > > +        if driver == "vimc":
> > > +            continue
> > > +
> > >          if not args.all and driver in drivers_tested:
> > >              continue
> > >  

-- 
Regards,

Laurent Pinchart