[libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a test candidate

[Kieran Bingham]

Hi Paul,

On 14/09/2021 02:04, Paul Elder wrote:
> As the vimc scaler prevents us from passing v4l2-compliance, skip it
> until the fix has been merged. Instead of removing it from the
> supported_pipelines list, add an extra check, since we will have the
> same construct later when we check for the kernel version.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  test/v4l2_compat/v4l2_compat_test.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py
> index ae892ced..6d304b6c 100755
> --- a/test/v4l2_compat/v4l2_compat_test.py
> +++ b/test/v4l2_compat/v4l2_compat_test.py
> @@ -134,6 +134,10 @@ def main(argv):
>          if driver not in supported_pipelines:
>              continue
>  
> +        # TODO: Add kernel version check

Add a kernel version check when ... vimc supports scaling ?

Either way,

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> +        if driver == "vimc":
> +            continue
> +
>          if not args.all and driver in drivers_tested:
>              continue
>  
>