[libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the ControlInfo ranges and defaults

[Naushir Patuck]

Hi David,

Thank you for your work.

On Mon, 28 Mar 2022 at 11:06, David Plowman via libcamera-devel <
libcamera-devel at lists.libcamera.org> wrote:

> Some of the values were listed incorrectly. Specifically:
>
> ExposureValue: the range is now centred correctly on zero
> Brightness: the default value (0.0) is made explicit
> Contrast: the default value is corrected to be 1.0
> Saturation: the default value is corrected to be 1.0
>
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
>

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>


> ---
>  include/libcamera/ipa/raspberrypi.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/libcamera/ipa/raspberrypi.h
> b/include/libcamera/ipa/raspberrypi.h
> index 7f705e49..6a56b008 100644
> --- a/include/libcamera/ipa/raspberrypi.h
> +++ b/include/libcamera/ipa/raspberrypi.h
> @@ -34,13 +34,13 @@ static const ControlInfoMap Controls({
>                 { &controls::AeMeteringMode,
> ControlInfo(controls::AeMeteringModeValues) },
>                 { &controls::AeConstraintMode,
> ControlInfo(controls::AeConstraintModeValues) },
>                 { &controls::AeExposureMode,
> ControlInfo(controls::AeExposureModeValues) },
> -               { &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },
> +               { &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f)
> },
>                 { &controls::AwbEnable, ControlInfo(false, true) },
>                 { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },
>                 { &controls::AwbMode, ControlInfo(controls::AwbModeValues)
> },
> -               { &controls::Brightness, ControlInfo(-1.0f, 1.0f) },
> -               { &controls::Contrast, ControlInfo(0.0f, 32.0f) },
> -               { &controls::Saturation, ControlInfo(0.0f, 32.0f) },
> +               { &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },
> +               { &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },
> +               { &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },
>                 { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },
>                 { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f,
> 16.0f) },
>                 { &controls::ScalerCrop, ControlInfo(Rectangle{},
> Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },
> --
> 2.30.2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220406/e9517c0e/attachment-0001.htm>