[libcamera-devel] [RFC PATCH 04/12] ipa: ipu3: Move the Frame Context queue to libipa

[Jacopo Mondi]

On Thu, Aug 04, 2022 at 02:54:37PM +0200, Jacopo Mondi via libcamera-devel wrote:
> Hi Umang,
>   I'm applying comments on top of Kierans' RFC and I have two
> questions here
> > > index 2f6bb672f7bb..55e82cd404f4 100644
> > > --- a/src/ipa/ipu3/ipu3.cpp
> > > +++ b/src/ipa/ipu3/ipu3.cpp
> > > @@ -38,6 +38,8 @@
> > >   #include "algorithms/tone_mapping.h"
> > >   #include "libipa/camera_sensor_helper.h"
> > > +#include "ipa_context.h"
> > > +
> > >   /* Minimum grid width, expressed as a number of cells */
> > >   static constexpr uint32_t kMinGridWidth = 16;
> > >   /* Maximum grid width, expressed as a number of cells */
> > > @@ -456,8 +458,7 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,
> > >   	/* Clean IPAActiveState at each reconfiguration. */
> > >   	context_.activeState = {};
> > > -	IPAFrameContext initFrameContext;
> > > -	context_.frameContexts.fill(initFrameContext);
> > > +	context_.frameContexts.clear();
> > context_.frameContexts.clear();
> >
> > Should also be done in IPAIPU3::stop().
> >
>
> I understand IPA::configure() is not enough, as we can have star/stop
> sequences without a reconfiguration in between.
>
> But why stop() and not start()
>

replying to myself after having re-read Kieran's reply to the comment:
start() can conflict with queueRequest().