[libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify test patterns listed for IMX519

[Kieran Bingham]

Quoting Umang Jain via libcamera-devel (2022-12-12 07:16:47)
> The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon
> inspecting the test pattern modes via v4l2-ctl utility, these test
> patterns do not comply with MIPI CCS v1.1 (Section 10.1).
> 
> Hence, omit from camera-sensor-properties database for now and add a
> comment for the same.
> 
> Fixes: e3b26b4c4eb2 ("libcamera: camera_sensor: Add IMX519 sensor properties")
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Sounds fine to me.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 04d80d6d..7f5e404e 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         .unitCellSize = { 1220, 1220 },
>                         .testPatternModes = {
>                                 { controls::draft::TestPatternModeOff, 0 },
> -                               { controls::draft::TestPatternModeColorBars, 1 },
>                                 { controls::draft::TestPatternModeSolidColor, 2 },
> -                               { controls::draft::TestPatternModeColorBarsFadeToGray, 3 },
>                                 { controls::draft::TestPatternModePn9, 4 },
> +                               /*
> +                                * The driver reports ColorBars and ColorBarsFadeToGray as well but
> +                                * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).
> +                                */
>                         },
>                 } },
>                 { "ov2740", {
> -- 
> 2.38.1
>