[libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify test patterns listed for IMX519

[Laurent Pinchart]

Hi Umang,

Thank you for the patch.

On Mon, Dec 12, 2022 at 12:46:47PM +0530, Umang Jain via libcamera-devel wrote:
> The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon
> inspecting the test pattern modes via v4l2-ctl utility, these test
> patterns do not comply with MIPI CCS v1.1 (Section 10.1).
> 
> Hence, omit from camera-sensor-properties database for now and add a
> comment for the same.
> 
> Fixes: e3b26b4c4eb2 ("libcamera: camera_sensor: Add IMX519 sensor properties")
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

I'm still puzzled by the blue-yellow colour bars pattern when selecting
test pattern 1. It could be a sensor misconfiguration, which would be
nice to fix. Not something we need to look at though, for this patch,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 04d80d6d..7f5e404e 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  			.unitCellSize = { 1220, 1220 },
>  			.testPatternModes = {
>  				{ controls::draft::TestPatternModeOff, 0 },
> -				{ controls::draft::TestPatternModeColorBars, 1 },
>  				{ controls::draft::TestPatternModeSolidColor, 2 },
> -				{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },
>  				{ controls::draft::TestPatternModePn9, 4 },
> +				/*
> +				 * The driver reports ColorBars and ColorBarsFadeToGray as well but
> +				 * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1).
> +				 */
>  			},
>  		} },
>  		{ "ov2740", {

-- 
Regards,

Laurent Pinchart