[libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder headers to appease the linter

[Jacopo Mondi]

Hi Paul

On Fri, Dec 16, 2022 at 09:29:22PM +0900, Paul Elder via libcamera-devel wrote:
> Re-order the header includes to appease the style-checker, so that when
> we add headers later (specifically, property_ids.h), it won't complain.
>

If it please the tool and avoid later conflicts..

> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index eb9ad65c..f658d75e 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -23,11 +23,11 @@
>  #include <libcamera/control_ids.h>
>  #include <libcamera/formats.h>
>  #include <libcamera/framebuffer.h>
> +#include <libcamera/request.h>
> +#include <libcamera/stream.h>

However I would have expected checkstyle to require an empty line here

Anyway, glory glory to the holy tool
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

>  #include <libcamera/ipa/core_ipa_interface.h>
>  #include <libcamera/ipa/rkisp1_ipa_interface.h>
>  #include <libcamera/ipa/rkisp1_ipa_proxy.h>
> -#include <libcamera/request.h>
> -#include <libcamera/stream.h>
>
>  #include "libcamera/internal/camera.h"
>  #include "libcamera/internal/camera_sensor.h"
> --
> 2.35.1
>