[libcamera-devel] [PATCH v9 01/18] pipeline: rkisp1: Reorder headers to appease the linter

Umang Jain umang.jain at ideasonboard.com
Wed Dec 21 09:26:55 CET 2022


Hi Paul,

Thank you for the patch.

On 12/16/22 5:59 PM, Paul Elder via libcamera-devel wrote:
> Re-order the header includes to appease the style-checker, so that when
> we add headers later (specifically, property_ids.h), it won't complain.
>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index eb9ad65c..f658d75e 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -23,11 +23,11 @@
>   #include <libcamera/control_ids.h>
>   #include <libcamera/formats.h>
>   #include <libcamera/framebuffer.h>
> +#include <libcamera/request.h>
> +#include <libcamera/stream.h>
>   #include <libcamera/ipa/core_ipa_interface.h>
>   #include <libcamera/ipa/rkisp1_ipa_interface.h>
>   #include <libcamera/ipa/rkisp1_ipa_proxy.h>
> -#include <libcamera/request.h>
> -#include <libcamera/stream.h>
>   
>   #include "libcamera/internal/camera.h"
>   #include "libcamera/internal/camera_sensor.h"



More information about the libcamera-devel mailing list