[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark the Embedded Data stream as external

Naushir Patuck naush at raspberrypi.com
Mon Jan 10 16:42:26 CET 2022


Remove the code that marks the Embedded Data stream as external with the Unicam
Image (RAW) stream. This was needed for legacy reasons when matching image and
embedded buffers, but is not needed any more.

Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index 168bbcef819c..a0cd501c8250 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)
 					<< format.toString();
 			return ret;
 		}
-
-		/*
-		 * If a RAW/Bayer stream has been requested by the application,
-		 * we must set both Unicam streams as external, even though the
-		 * application may only request RAW frames. This is because we
-		 * match timestamps on both streams to synchronise buffers.
-		 */
-		if (rawStream)
-			data->unicam_[Unicam::Embedded].setExternal(true);
 	}
 
 	/*
-- 
2.25.1



More information about the libcamera-devel mailing list