[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Demote the category of a logging message

[Naushir Patuck]

Hi Kieran,

Thanks for the review!

On Mon, 10 Jan 2022 at 14:41, Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> Quoting Naushir Patuck (2022-01-10 10:23:42)
> > Switch the "no buffers available" log message from Info to Debug so that
> it does
> > not get output by default.
> >
>
> I can imagine this is causing unnecessary concern with users?
>

This is exactly the reason for this change :-)

Naush


>
> And I believe it's valid for streams to not have a buffer when queueing
> a request in all cases, so I think this is reasonable.
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > ---
> >  src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> > index bab80d25ad1a..a4159e20b068 100644
> > --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> > +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> > @@ -130,8 +130,8 @@ int Stream::queueBuffer(FrameBuffer *buffer)
> >          */
> >         if (!buffer) {
> >                 if (availableBuffers_.empty()) {
> > -                       LOG(RPISTREAM, Info) << "No buffers available
> for "
> > -                                               << name_;
> > +                       LOG(RPISTREAM, Debug) << "No buffers available
> for "
> > +                                             << name_;
> >                         /*
> >                          * Note that we need to queue an internal buffer
> as soon
> >                          * as one becomes available.
> > --
> > 2.25.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220110/1384b56f/attachment.htm>