[libcamera-devel] [PATCH 09/15] DNI: ipa: raspberrypi: Code refactoring to match style guidelines

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jul 25 22:56:22 CEST 2022


Hi Naush,

Thank you for the patch.

On Mon, Jul 25, 2022 at 02:46:33PM +0100, Naushir Patuck via libcamera-devel wrote:
> Refactor the source files src/ipa/raspberrypi/controller/rps/[f|g|l]* to match the
> recommended formatting guidelines for the libcamera project. The vast majority
> of changes in this commit comprise of switching from snake_case to CamelCase,
> and starting class member functions with a lower case character.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/rpi/focus.cpp | 14 ++--
>  src/ipa/raspberrypi/controller/rpi/focus.hpp |  4 +-
>  src/ipa/raspberrypi/controller/rpi/geq.cpp   | 48 +++++++-------
>  src/ipa/raspberrypi/controller/rpi/geq.hpp   |  6 +-
>  src/ipa/raspberrypi/controller/rpi/lux.cpp   | 70 ++++++++++----------
>  src/ipa/raspberrypi/controller/rpi/lux.hpp   | 22 +++---
>  6 files changed, 81 insertions(+), 83 deletions(-)

[snip]

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list