[libcamera-devel] [PATCH] ipa: raspberrypi: Add functional include to pwl.h

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jul 28 15:27:18 CEST 2022


Hi Eric,

Thank you for the patch.

On Thu, Jul 28, 2022 at 01:01:30PM +0100, Eric Curtin wrote:
> Was failing without this include on Fedora 36 compiler toolchain.

Could you tell what compiler and compiler version that is ? Could you
also please share the error message ?

> Signed-off-by: Eric Curtin <ecurtin at redhat.com>
> ---
>  src/ipa/raspberrypi/controller/pwl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h
> index 546482cd..691c4700 100644
> --- a/src/ipa/raspberrypi/controller/pwl.h
> +++ b/src/ipa/raspberrypi/controller/pwl.h
> @@ -7,6 +7,7 @@
>  #pragma once
>  
>  #include <math.h>
> +#include <functional>

Alphabetical order please. I can fix that when applying, no need to send
a v2 just for this.

>  #include <vector>
>  
>  #include "libcamera/internal/yaml_parser.h"

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list