[libcamera-devel] [PATCH] ipa: raspberrypi: Add functional include to pwl.h

[Eric Curtin]

On Thu, 28 Jul 2022 at 14:27, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hi Eric,
>
> Thank you for the patch.
>
> On Thu, Jul 28, 2022 at 01:01:30PM +0100, Eric Curtin wrote:
> > Was failing without this include on Fedora 36 compiler toolchain.
>
> Could you tell what compiler and compiler version that is ? Could you
> also please share the error message ?

Fedora 36

gcc --version
gcc (GCC) 12.1.1 20220507 (Red Hat 12.1.1-1)
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

You can see the compiler error here:

https://github.com/ericcurtin/twincam/runs/7558719653

>
> > Signed-off-by: Eric Curtin <ecurtin at redhat.com>
> > ---
> >  src/ipa/raspberrypi/controller/pwl.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h
> > index 546482cd..691c4700 100644
> > --- a/src/ipa/raspberrypi/controller/pwl.h
> > +++ b/src/ipa/raspberrypi/controller/pwl.h
> > @@ -7,6 +7,7 @@
> >  #pragma once
> >
> >  #include <math.h>
> > +#include <functional>
>
> Alphabetical order please. I can fix that when applying, no need to send
> a v2 just for this.

Sorry I wasn't sure if you liked to split the C and C++ ones, took the
wrong guess and just sorted the C++ ones

>
> >  #include <vector>
> >
> >  #include "libcamera/internal/yaml_parser.h"
>
> --
> Regards,
>
> Laurent Pinchart
>