[libcamera-devel] [PATCH] meson: options: Disable pycamera by default

[Laurent Pinchart]

Hi Javier,

Thank you for the patch.

On Thu, Jun 23, 2022 at 02:10:38PM +0200, Javier Martinez Canillas wrote:
> The libcamera Python bindings is still experimental and it relies on some
> features in pybind11 that are not yet upstreamed, so a special branch has
> to be downloaded as a subproject.
> 
> This conflicts with the build process used by most Linux distributions,
> since there is expected that all the dependencies will be fulfilled by
> -devel packages present in the build root.
> 
> To allow libcamera to be built by distros, let's disable the pycamera by
> default. This can still be enabled with `meson build -Dpycamera=enabled`.
> 
> Suggested-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> Signed-off-by: Javier Martinez Canillas <javierm at redhat.com>

Sounds sensible to me. Any volunteer to engage with upstream pybind11 to
get the features we need in their master branch ? :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> 
>  meson_options.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index ca00c78e8134..7a9aecfc60f5 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -61,5 +61,5 @@ option('v4l2',
>  
>  option('pycamera',
>          type : 'feature',
> -        value : 'auto',
> +        value : 'disabled',
>          description : 'Enable libcamera Python bindings (experimental)')

-- 
Regards,

Laurent Pinchart