[libcamera-devel] [PATCH] meson: options: Disable pycamera by default

[Tomi Valkeinen]

On 23/06/2022 15:14, Laurent Pinchart wrote:
> Hi Javier,
> 
> Thank you for the patch.
> 
> On Thu, Jun 23, 2022 at 02:10:38PM +0200, Javier Martinez Canillas wrote:
>> The libcamera Python bindings is still experimental and it relies on some
>> features in pybind11 that are not yet upstreamed, so a special branch has
>> to be downloaded as a subproject.
>>
>> This conflicts with the build process used by most Linux distributions,
>> since there is expected that all the dependencies will be fulfilled by
>> -devel packages present in the build root.
>>
>> To allow libcamera to be built by distros, let's disable the pycamera by
>> default. This can still be enabled with `meson build -Dpycamera=enabled`.
>>
>> Suggested-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>> Signed-off-by: Javier Martinez Canillas <javierm at redhat.com>
> 
> Sounds sensible to me. Any volunteer to engage with upstream pybind11 to
> get the features we need in their master branch ? :-)

I know you're talking to me there...

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

  Tomi