[libcamera-devel] [PATCH v3 0/7] Raspberry Pi AGC digital gain fixes

[Naushir Patuck]

Hi,

Any chance of another review for this one please?

Thanks,
Naush

On Mon, 26 Sept 2022 at 10:57, Naushir Patuck <naush at raspberrypi.com> wrote:

> Hi,
>
> Version 3 of this series addresses the comments from Umang and David -
> mostly
> minor typos, and a simplification to the new Metadata:mergeCopy() function.
>
> Thanks,
> Naush
>
> Naushir Patuck (7):
>   delayed_controls: Template the ControlRingBuffer class
>   delayed_controls: Add user cookie to DelayedControls
>   tests: delayed_controls: Add cookie value test
>   ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
>   ipa: raspberrypi: Use an array of RPiController::Metadata objects
>   pipeline: ipa: raspberrypi: Use IPA cookies
>   ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
>
>  include/libcamera/internal/delayed_controls.h | 21 +++--
>  include/libcamera/ipa/raspberrypi.mojom       |  3 +-
>  src/ipa/raspberrypi/controller/metadata.h     | 10 +++
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    | 10 ++-
>  src/ipa/raspberrypi/raspberrypi.cpp           | 82 ++++++++++++-------
>  src/libcamera/delayed_controls.cpp            | 20 +++--
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  3 +-
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 12 +--
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  3 +-
>  test/delayed_controls.cpp                     | 52 +++++++++++-
>  10 files changed, 156 insertions(+), 60 deletions(-)
>
> --
> 2.25.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20221003/e9264316/attachment.htm>