[libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays for the IMX296

[David Plowman]

Hi Naush

Thanks for the patch!

On Wed, 28 Sept 2022 at 08:07, Jacopo Mondi via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> Hi Naush
>
> On Mon, Sep 26, 2022 at 10:36:13AM +0100, Naushir Patuck via libcamera-devel wrote:
> > The IMX296 implements a 2 frame delay for exposure, gain and vertical blanking
> > changes. Report this in the camera helper.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
>
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
>

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Thanks
David

> Thanks
>   j
> > ---
> >  src/ipa/raspberrypi/cam_helper_imx296.cpp | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp
> > index ab1d157aaf45..09f828ea6249 100644
> > --- a/src/ipa/raspberrypi/cam_helper_imx296.cpp
> > +++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp
> > @@ -23,6 +23,7 @@ public:
> >       double gain(uint32_t gainCode) const override;
> >       uint32_t exposureLines(Duration exposure) const override;
> >       Duration exposure(uint32_t exposureLines) const override;
> > +     void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay) const override;
> >
> >  private:
> >       static constexpr uint32_t maxGainCode = 239;
> > @@ -61,6 +62,14 @@ Duration CamHelperImx296::exposure(uint32_t exposureLines) const
> >       return exposureLines * timePerLine + 14.26us;
> >  }
> >
> > +void CamHelperImx296::getDelays(int &exposureDelay, int &gainDelay,
> > +                             int &vblankDelay) const
> > +{
> > +     exposureDelay = 2;
> > +     gainDelay = 2;
> > +     vblankDelay = 2;
> > +}
> > +
> >  static CamHelper *create()
> >  {
> >       return new CamHelperImx296();
> > --
> > 2.25.1
> >