[libcamera-devel] [PATCH] py: Support controls that are ControlTypeNone

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Fri Sep 30 22:04:22 CEST 2022


On 30/09/2022 18:37, Kieran Bingham via libcamera-devel wrote:
> Quoting David Plowman via libcamera-devel (2022-09-30 13:18:12)
>> Such controls can now be created when a control doesn't have a
>> reasonable or obvious default value. We support them using Python's
>> "None" value, rather than generating a runtime error.
>>
> 
> This sounds correct and reasonable to me.

I agree.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

> This looks like the sort of thing that should have a unit test. I assume
> you're testing it with picamera2 already though.
> 
> Tomi, Have we got anywhere we can add tests for things like this ?

We have test/py/unittests.py, although we probably want to split it up 
to multiple files if we start adding more.

  Tomi


More information about the libcamera-devel mailing list