[libcamera-devel] softISP for libcamera

[Kieran Bingham]

Hi Pavel,

Quoting Pavel Machek via libcamera-devel (2023-12-04 23:04:03)
> Hi!
> 
> > First, thanks for softisp efforts. I worked on something similar but
> > did not get anywhere near mergeable state. (My hacks are at
> > git at gitlab.com:tui/libcamera.git,  new-ae2 branch).
> > 
> > I tried to test the code on PinePhone, so I started from 
> > 
> > commit 10c27dc4cf922fb79e9f3a3cf44602f472bbc102 (HEAD -> sisp, softisp/SoftwareISP-v02, origin/sisp)
> > Author: Andrey Konovalov <andrey.konovalov at linaro.org>
> > Date:   Fri Dec 1 17:01:30 2023 +0300
> > 
> > But I'm getting build error:
> > 
> > ../src/libcamera/pipeline/simple/simple.cpp:28:10: fatal error: libcamera/ipa/soft_ipa_interface.h: No such file or directory
> >    28 | #include <libcamera/ipa/soft_ipa_interface.h>
> >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > 
> > ...and it sounds like libcamera/ipa/soft_ipa_interface.h is missing
> > from the repository?
> 
> It may be that I failed to enable simple/linaro pipeline in the
> meson. It certainly does not list it. If I try with parent commit, it
> builds okay, but I guess that means code is not enabled.

Could you provide this feedback on Andrey's patches that have been
posted [0] please? That way it will be in the right context.

I'm sure any other review comments you have on the series may be useful
too as you have also explored this area.

[0] https://lists.libcamera.org/pipermail/libcamera-devel/2023-December/039700.html

--
Kieran.

> 
> Best regards,
>                                                                 Pavel
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.