[libcamera-devel] softISP for libcamera

[Pavel Machek]

Hi!

> I forgot to add the README.soft-isp.txt, in particular the command to setup the build:
> 
> $ meson setup -Dprefix=$INSTALL_DIR -Dpipelines=simple/linaro -Dipas=simple/linaro $BUILD_DIR
> $ ninja -C $BUILD_DIR
> $ ninja -C $BUILD_DIR install
> 
> With "-Dpipelines=simple/linaro -Dipas=simple/linaro" the libcamera/ipa/soft_ipa_interface.h
> will be generated OK.

Is something like this needed?

Without that, I get segfault on unsupported configuration. With it, I
get: ...which is a bit better.

[17:16:48.471346880] [10272] ERROR SimplePipeline simple.cpp:1506 Searching for device
[17:16:48.472680253] [10271] ERROR SimplePipeline simple.cpp:1166 No formats -- first?
Failed to get default stream configuration
Failed to create camera session
mobian at mobian:~/g/libcamera$ git show > /tmp/delme

Best regards,
									Pavel

index 609c12d7..84643b04 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -1162,6 +1162,14 @@ SimplePipelineHandler::generateConfiguration(Camera *camera, Span<const StreamRo
 	 */
 	for ([[maybe_unused]] StreamRole role : roles) {
 		StreamConfiguration cfg{ StreamFormats{ formats } };
+		if (! formats.begin()->first) {
+		  LOG(SimplePipeline, Error)
+			<< "No formats -- first?";
+		  continue;
+		}
+		  LOG(SimplePipeline, Error)
+			<< "Going through roles?";
+
 		cfg.pixelFormat = formats.begin()->first;
 		cfg.size = formats.begin()->second[0].max;
 
-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20231205/5847f8bd/attachment.sig>