[libcamera-devel] [PATCH 00/11] libcamera: introduce Software ISP and Software IPA

[Bryan O'Donoghue]

On 14/12/2023 12:13, Hans de Goede wrote:
> Hi All,
> 
> Here is a new, now non RFC because believed to be mostly ready
> for merging, version of the Software ISP work.


Thanks for sending this out.

One thing I'm noticing when compiling is a load of warnings about 
undocumented variables.

meson setup -Dprefix=/home/deckard/Development/FireFox/libcamera-install 
-Dpipelines=simple/simple -Dipas=simple/simple build.swisp

ninja -j `nproc` -C build.swisp
ninja: Entering directory `build.swisp'
[12/184] Generating src/ipa-priv-key with a custom command
........+...+...+.+........+..................+.......+...+..+.+......+...+......+.....+....+......+.........+......+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*......+....+..+....+.....+......+.+...............+........+....+......+..+...............+.............+......+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*..+........+...+...+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
....+......+.....+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*...+............+....................+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*...............+.......+............+...+..+...+..................+.+........+.............+.........+.....+.+...+..+.......+.....+.......+.....+.+...+............+...+..+.........+.........+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[43/184] Generating src/libcamera/ipa_pub_key_cpp with a custom command
writing RSA key
[184/184] Generating Documentation/doxygen with a custom command
/home/deckard/Development/libcamera-downstream/include/libcamera/internal/software_isp/debayer.h:30: 
warning: Compound libcamera::Debayer is not documented.
/home/deckard/Development/libcamera-downstream/include/libcamera/internal/software_isp/debayer_cpu.h:25: 
warning: Compound libcamera::DebayerCpu is not documented.
/home/deckard/Development/libcamera-downstream/include/libcamera/internal/software_isp/debayer_params.h:15: 
warning: Compound libcamera::DebayerParams is not documented.
/home/deckard/Development/libcamera-downstream/include/libcamera/internal/shared_mem_object.h:23: 
warning: Compound libcamera::SharedMemObject is not documented.
/home/deckard/Development/libcamera-downstream/include/libcamera/internal/software_isp.h:34: 
warning: Compound libcamera::SoftwareIsp is not documented.

Not sure if you or Andrey see that yourselves but one to be aware of for V2.

---
bod