[libcamera-devel] [PATCH 00/11] libcamera: introduce Software ISP and Software IPA

[Hans de Goede]

Hi Bryan,

On 12/14/23 15:40, Bryan O'Donoghue wrote:
> On 14/12/2023 12:13, Hans de Goede wrote:
>> Hi All,
>>
>> Here is a new, now non RFC because believed to be mostly ready
>> for merging, version of the Software ISP work.
> 
> 
> Thanks for sending this out.

You're welcome.

> One thing I'm noticing when compiling is a load of warnings about undocumented variables.
<snip>
> Not sure if you or Andrey see that yourselves but one to be aware of for V2.

Quoting from the cover-letter:

"""
Known open items:
- The AWB red/blue gain calculations needs to be moved to the IPA
  and IPA then needs to pass a DebayerParams struct back to the
  SwIsp
- Properly document all methods / attributed for doxygen
"""

So this is a known issue.

BTW I'm currently working on adding support for 10bpp unpacked
bayer and while working on this I noticed a small bug in the swstats
code, you may want to squash in this fix:


--- a/src/libcamera/software_isp/swstats_cpu.cpp
+++ b/src/libcamera/software_isp/swstats_cpu.cpp
@@ -139,7 +139,7 @@ int SwStatsCpu::configure(const StreamConfiguration &inputCfg)
 		bpp_ = 10;
 		patternSize_.height = 2;
 		patternSize_.width = 4; /* 5 bytes per *4* pixels */
-		y_skip_mask_ = 0x0c; /* Skip every 3th and 4th line */
+		y_skip_mask_ = 0x02; /* Skip every 3th and 4th line */
 		x_shift_ = 0;
 
 		switch (bayerFormat.order) {


Regards,

Hans