[libcamera-devel] [PATCH 00/11] libcamera: introduce Software ISP and Software IPA

[Bryan O'Donoghue]

On 14/12/2023 14:47, Hans de Goede wrote:
> Hi Bryan,
> 
> On 12/14/23 15:40, Bryan O'Donoghue wrote:
>> On 14/12/2023 12:13, Hans de Goede wrote:
>>> Hi All,
>>>
>>> Here is a new, now non RFC because believed to be mostly ready
>>> for merging, version of the Software ISP work.
>>
>>
>> Thanks for sending this out.
> 
> You're welcome.
> 
>> One thing I'm noticing when compiling is a load of warnings about undocumented variables.
> <snip>
>> Not sure if you or Andrey see that yourselves but one to be aware of for V2.
> 
> Quoting from the cover-letter:
> 
> """
> Known open items:
> - The AWB red/blue gain calculations needs to be moved to the IPA
>    and IPA then needs to pass a DebayerParams struct back to the
>    SwIsp
> - Properly document all methods / attributed for doxygen
> """
> 
> So this is a known issue.
> 
> BTW I'm currently working on adding support for 10bpp unpacked
> bayer and while working on this I noticed a small bug in the swstats
> code, you may want to squash in this fix:

Applied that change.

I'm comparing to your earlier branch

commit ae92fa44991ded151c63d5d202efdacc9d640aff (HEAD -> 
SoftwareISP-v01-hans1, softisp/SoftwareISP-v01-hans1)
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Thu Nov 30 20:13:29 2023 +0100


On the earlier branch I get 30fps @ 68% CPU usage. On this branch I'm 
getting 18fps @ 100%.

Old branch:
https://gitlab.freedesktop.org/camera/libcamera-softisp/-/blob/bod/SoftwareISP-v04-review/v1-image.jpg

New branch:
https://gitlab.freedesktop.org/camera/libcamera-softisp/-/blob/bod/SoftwareISP-v04-review/v1-posted-image.jpg

Seems to be eating alot more cycles and producing a more pinkish result 
on my hw.

---
bod