[libcamera-devel] [PATCH v1 3/4] pipeline: ipu3: Drop unused code

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Feb 6 18:03:55 CET 2023


Commit 1a614866a29c ("libcamera: camera_sensor: Validate Transform") has
removed usage of the IPU3CameraData::rotationTransform_ but hasn't
removed the field itself, nor its initialization. Drop those as they're
unused.

Fixes: 1a614866a29c ("libcamera: camera_sensor: Validate Transform")
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 3a569c7e0031..355cb0cb76b8 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -73,7 +73,6 @@ public:
 	Stream rawStream_;
 
 	Rectangle cropRegion_;
-	Transform rotationTransform_;
 
 	std::unique_ptr<DelayedControls> delayedCtrls_;
 	IPU3Frames frameInfos_;
@@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras()
 					   << cio2->sensor()->id()
 					   << ". Assume rotation 0";
 
-		int32_t rotationValue = rotation.value_or(0);
-		bool success;
-		data->rotationTransform_ = transformFromRotation(rotationValue, &success);
-		if (!success)
-			LOG(IPU3, Warning) << "Invalid rotation of " << rotationValue
-					   << " degrees: ignoring";
-
 		/**
 		 * \todo Dynamically assign ImgU and output devices to each
 		 * stream and camera; as of now, limit support to two cameras
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list