[libcamera-devel] [PATCH v1 2/4] libcamera: camera_sensor: Fix typo in comment
Umang Jain
umang.jain at ideasonboard.com
Wed Feb 8 11:26:18 CET 2023
Hi Laurent,
Thank you for the patch
On 2/6/23 10:33 PM, Laurent Pinchart via libcamera-devel wrote:
> Fix a typo introduced in a comment when refactoring transformation
> handling in the CameraSensor class.
>
> Fixes: 1a614866a29c ("libcamera: camera_sensor: Validate Transform")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
> src/libcamera/camera_sensor.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
> index 11117502d817..274ed419ddfd 100644
> --- a/src/libcamera/camera_sensor.cpp
> +++ b/src/libcamera/camera_sensor.cpp
> @@ -1023,8 +1023,8 @@ Transform CameraSensor::validateTransform(Transform *transform) const
>
> /*
> * We combine the platform and user transform, but must "adjust away"
> - * any combined result that includes a transform, as we can't do those.
> - * In this case, flipping only the transpose bit is helpful to
> + * any combined result that includes a transposition, as we can't do
> + * those. In this case, flipping only the transpose bit is helpful to
> * applications - they either get the transform they requested, or have
> * to do a simple transpose themselves (they don't have to worry about
> * the other possible cases).
More information about the libcamera-devel
mailing list