[libcamera-devel] [PATCH v9 0/8] Add CrOS JEA implementation
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jan 16 01:28:00 CET 2023
Hello,
Here's a new version of Harvey's JEA series, with all the comments I've
sent during review of v8 addressed. Up to the last patch in v8 I thought
I would address all comments when applying, so I folded them in my tree,
and it seemed a waste of effort to delete it all and let Harvey do the
same.
Compared to v8, I've also added patch 6/8 that returns an int error code
from the generateThumbnail() function.
Harvey, patch 8/8 may be ready, but I didn't add a Reviewed-by tag as
I've asked a few questions in the review of v8. Depending on the answer,
I could push v9 as-is. Your review of 6/8 would be appreciated (and feel
free to push back if you don't think it's a good idea), as well as a
test of the whole series to make sure I didn't break anything (I've only
compile-tested this).
Harvey Yang (7):
libcamera: framebuffer: Allow inheritance of FrameBuffer
android: framebuffer: Add HALFrameBuffer and replace FrameBuffer
android: jpeg: Add meson.build in src/android/jpeg
android: jpeg: Add an internal Encoder class in EncoderLibJpeg
android: jpeg: Move generateThumbnail from PostProcessorJpeg to
Encoder
android: jpeg: Pass StreamBuffer to Encoder::encoder
android: jpeg: Add JEA implementation
Laurent Pinchart (1):
android: jpeg: Return an error code from generateThumbnail()
include/libcamera/framebuffer.h | 3 +-
src/android/camera_device.cpp | 5 +-
src/android/camera_device.h | 3 +-
src/android/camera_request.h | 3 +-
src/android/cros/camera3_hal.cpp | 4 +-
src/android/cros_mojo_token.h | 12 ++
src/android/frame_buffer_allocator.h | 7 +-
src/android/hal_framebuffer.cpp | 22 ++++
src/android/hal_framebuffer.h | 26 +++++
src/android/jpeg/encoder.h | 9 +-
src/android/jpeg/encoder_jea.cpp | 103 +++++++++++++++++
src/android/jpeg/encoder_jea.h | 35 ++++++
src/android/jpeg/encoder_libjpeg.cpp | 108 ++++++++++++++----
src/android/jpeg/encoder_libjpeg.h | 46 +++++---
src/android/jpeg/meson.build | 17 +++
src/android/jpeg/post_processor_jpeg.cpp | 65 ++---------
src/android/jpeg/post_processor_jpeg.h | 10 +-
src/android/meson.build | 6 +-
.../mm/cros_frame_buffer_allocator.cpp | 9 +-
.../mm/generic_frame_buffer_allocator.cpp | 11 +-
20 files changed, 385 insertions(+), 119 deletions(-)
create mode 100644 src/android/cros_mojo_token.h
create mode 100644 src/android/hal_framebuffer.cpp
create mode 100644 src/android/hal_framebuffer.h
create mode 100644 src/android/jpeg/encoder_jea.cpp
create mode 100644 src/android/jpeg/encoder_jea.h
create mode 100644 src/android/jpeg/meson.build
base-commit: aed615e1730d17a3da77ea22d5af43440cc4d873
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list