[libcamera-devel] [PATCH v9 1/8] libcamera: framebuffer: Allow inheritance of FrameBuffer

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jan 16 01:28:01 CET 2023


From: Harvey Yang <chenghaoyang at chromium.org>

To add buffer_handle_t access in android, this patch allows inheritance
of FrameBuffer to add a derived class in android.

Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Han-Lin Chen <hanlinchen at chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 include/libcamera/framebuffer.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h
index 695539993f96..612448290a24 100644
--- a/include/libcamera/framebuffer.h
+++ b/include/libcamera/framebuffer.h
@@ -46,7 +46,7 @@ private:
 	std::vector<Plane> planes_;
 };
 
-class FrameBuffer final : public Extensible
+class FrameBuffer : public Extensible
 {
 	LIBCAMERA_DECLARE_PRIVATE()
 
@@ -60,6 +60,7 @@ public:
 
 	FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);
 	FrameBuffer(std::unique_ptr<Private> d);
+	virtual ~FrameBuffer() {}
 
 	const std::vector<Plane> &planes() const;
 	Request *request() const;
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list