[libcamera-devel] [PATCH 3/4] utils: checkstyle.py: Derive Amendment from Commit

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Jul 11 15:39:14 CEST 2023

The Amendment commit class is derived from the StagedChanges class
(which in turn derives from the Commit base class), however there is no
code sharing between Amendment and StagedChanges other than the call to
initalise through the base Commit class.

Refactor the inheritance to make an Amendment derive directly from

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
 utils/checkstyle.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index 2ba3165b8ecd..5663af811961 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -269,9 +269,9 @@ class StagedChanges(Commit):
         return parse_diff(diff.splitlines(True))
-class Amendment(StagedChanges):
+class Amendment(Commit):
     def __init__(self):
-        StagedChanges.__init__(self)
+        Commit.__init__(self, '')
     def _parse(self):
         # Create a title using HEAD commit

More information about the libcamera-devel mailing list