[libcamera-devel] [PATCH 2/4] utils: checkstyle.py: Initialise staged trailers

Umang Jain umang.jain at ideasonboard.com
Tue Jul 11 15:49:00 CEST 2023


Hi Kieran

Thank you  for the patch.

On 7/11/23 7:09 PM, Kieran Bingham via libcamera-devel wrote:
> There are no possible Trailers for staged changes as the commit message
> has not yet been written.
>
> Initialise the empty trailers when the commit object is initialised.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   utils/checkstyle.py | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index 5a1268064d31..2ba3165b8ecd 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -253,6 +253,9 @@ class StagedChanges(Commit):
>       def __init__(self):
>           Commit.__init__(self, '')
>   
> +        # There are no trailers to parse on a Staged Change.
> +        self._trailers = []
> +
>       def _parse(self):
>           ret = subprocess.run(['git', 'diff', '--staged', '--name-status'],
>                                stdout=subprocess.PIPE).stdout.decode('utf-8')



More information about the libcamera-devel mailing list