[libcamera-devel] "Software ISP" -- where to put it, neccessary hooks

Kieran Bingham kieran.bingham at ideasonboard.com
Sat Jul 15 10:18:07 CEST 2023


Hi Pavel,

Quoting Pavel Machek (2023-07-14 19:32:56)
> Hi!
> 
> > > ah yes - good point - there should be the soft-isp component that the
> > > pipeline handler instantiates, which would be src/libcamera/softisp/ ?
> > 
> > That's a good location for now, we can always reshuffle things later.
> 
> Could I ask for review?

Certainly, Code reviews take place here on the mailing list.

> Code is at https://gitlab.com/tui/libcamera/-/tree/new-ae2 , and it
> should have working auto-exposure. Long term, RPi code should move
> into softisp/ and be made more generic, but it would be nice to get
> something merged sooner than that.

For review, could you format your series with git-format-patch and
submit it to the list with a cover letter please?

--
Regards

Kieran

> 
> Best regards,
>                                                                 Pavel
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.


More information about the libcamera-devel mailing list