[libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add IMX327 helper

Kieran Bingham kieran.bingham at ideasonboard.com
Fri May 19 18:54:33 CEST 2023


Quoting Benjamin Bara (2023-05-19 17:40:55)
> Hi!
> 
> On Fri, 19 May 2023 at 17:57, Kieran Bingham
> <kieran.bingham at ideasonboard.com> wrote:
> > I would indeed rather add references to existing compatibles than
> > duplicate entire Helper classes where the result would be identical for
> > equivalent devices.
> 
> Yes, I think so too - but unfortunately it leads to an error for now, as
> it would redefine:
> libcamera::ipa::CameraSensorHelperFactory<libcamera::ipa::CameraSensorHelperImx290>
> libcamera::ipa::global_CameraSensorHelperImx290Factory’

Well then lets stick with your patch and we can see if we can optimise
reuse in the future.

I'll queue the patch up for merge.

Thanks,

Kieran

> 
> Regards
> Benjamin


More information about the libcamera-devel mailing list