[libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add IMX327 helper

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon May 29 11:59:59 CEST 2023


On Fri, May 19, 2023 at 05:54:33PM +0100, Kieran Bingham via libcamera-devel wrote:
> Quoting Benjamin Bara (2023-05-19 17:40:55)
> > On Fri, 19 May 2023 at 17:57, Kieran Bingham wrote:
> > > I would indeed rather add references to existing compatibles than
> > > duplicate entire Helper classes where the result would be identical for
> > > equivalent devices.
> > 
> > Yes, I think so too - but unfortunately it leads to an error for now, as
> > it would redefine:
> > libcamera::ipa::CameraSensorHelperFactory<libcamera::ipa::CameraSensorHelperImx290>
> > libcamera::ipa::global_CameraSensorHelperImx290Factory’
> 
> Well then lets stick with your patch and we can see if we can optimise
> reuse in the future.
> 
> I'll queue the patch up for merge.

The alphabetical order is now messed up :-( Could you please send a fix
?

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list