[libcamera-devel] [PATCH v4 2/5] ipa: rpi: agc: Reorganise code for multi-channel AGC

David Plowman david.plowman at raspberrypi.com
Fri Sep 15 16:58:40 CEST 2023


I thought we did have -Wall, -Werror set. If not, how would I set that?

Anyway, would you rather have an extra patch in this set, or a lone
patch that can be applied after?

David

On Fri, 15 Sept 2023 at 15:53, Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Quoting David Plowman (2023-09-15 15:43:15)
> > Indeed, I think I just moved the code so the problem has presumably
> > been there a little while. So probably best to submit a new patch to
> > fix it? Good thing Kieran's compiler was suitably picky...
> >
>
> This is why I'm a fan of -Wall,-Werror - even if lots of people
> hate it ;-)
>
> I really should try to fix the coverity checker sometime too. It stopped
> working and I never did repair it....
>
>
> --
> Kieran


More information about the libcamera-devel mailing list