[libcamera-devel] [PATCH v4 2/5] ipa: rpi: agc: Reorganise code for multi-channel AGC

[Kieran Bingham]

Quoting David Plowman (2023-09-15 15:58:40)
> I thought we did have -Wall, -Werror set. If not, how would I set that?
> 

Sorry for the confusion - I mean in general. libcamera sets werror in
the top of the meson.build project file.

But many people don't like failing to build because of warnings...

> Anyway, would you rather have an extra patch in this set, or a lone
> patch that can be applied after?

I'm not sure - that depends on the patch?

Is it just a fixup to this patch? or a fix before hand, and then a fix
to this patch ?

It's better not to have a patch that introduces 'known bad code' - so
something that fixes this patch would be best IMO.

Is there more than just fixing the two locations in this patch ?

--
Kieran

> 
> David
> 
> On Fri, 15 Sept 2023 at 15:53, Kieran Bingham
> <kieran.bingham at ideasonboard.com> wrote:
> >
> > Quoting David Plowman (2023-09-15 15:43:15)
> > > Indeed, I think I just moved the code so the problem has presumably
> > > been there a little while. So probably best to submit a new patch to
> > > fix it? Good thing Kieran's compiler was suitably picky...
> > >
> >
> > This is why I'm a fan of -Wall,-Werror - even if lots of people
> > hate it ;-)
> >
> > I really should try to fix the coverity checker sometime too. It stopped
> > working and I never did repair it....
> >
> >
> > --
> > Kieran