[PATCH] ipa: rpi: Fix wrong frame integration difference value for OV9281
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Dec 9 11:52:43 CET 2024
Hi Naush,
Thank you for the patch.
On Mon, Dec 09, 2024 at 10:47:23AM +0000, Naushir Patuck wrote:
> The frameIntegrationDiff value should be 25, otherwise we see invalid
> frames when integration times are set to large values.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
I'll trust you on that.
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> index a65c8ac08c1c..96f7fff499f5 100644
> --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> @@ -25,7 +25,7 @@ private:
> * Smallest difference between the frame length and integration time,
> * in units of lines.
> */
> - static constexpr int frameIntegrationDiff = 4;
> + static constexpr int frameIntegrationDiff = 25;
> };
>
> /*
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list