[PATCH] ipa: rpi: Fix wrong frame integration difference value for OV9281

Dave Stevenson dave.stevenson at raspberrypi.com
Mon Dec 9 11:52:59 CET 2024


Thanks Naush

On Mon, 9 Dec 2024 at 10:47, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> The frameIntegrationDiff value should be 25, otherwise we see invalid
> frames when integration times are set to large values.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Tested-by: Dave Stevenson <dave.stevenson at raspberrypi.com>

I'm sorting a patch for the kernel driver too, as that has
OV9282_EXPOSURE_OFFSET set to 12.

  Dave

> ---
>  src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> index a65c8ac08c1c..96f7fff499f5 100644
> --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp
> @@ -25,7 +25,7 @@ private:
>          * Smallest difference between the frame length and integration time,
>          * in units of lines.
>          */
> -       static constexpr int frameIntegrationDiff = 4;
> +       static constexpr int frameIntegrationDiff = 25;
>  };
>
>  /*
> --
> 2.43.0
>


More information about the libcamera-devel mailing list