[PATCH v4 12/23] libtuning: Be a bit more verbose

[Stefan Klug]

Hi Dan,

Thanks for the review.

On Fri, Jul 05, 2024 at 05:01:39PM +0100, Dan Scally wrote:
> Hi Stefan
> 
> On 05/07/2024 15:41, Stefan Klug wrote:
> > Print a info on every image that gets processed and a warning on every
> > image that gets ignored.
> > 
> > Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> > Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> > ---
> >   utils/tuning/libtuning/utils.py | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py
> > index 93c6c94ea2b0..dacda11312a2 100644
> > --- a/utils/tuning/libtuning/utils.py
> > +++ b/utils/tuning/libtuning/utils.py
> > @@ -92,7 +92,9 @@ def load_images(input_dir: str, config: dict, load_nonlsc: bool, load_lsc: bool)
> >       images = []
> >       for f in files:
> >           color, lux, lsc_only = _parse_image_filename(f)
> > +        logger.info(f'Process image "{f.name}" (color={color}, lux={lux}, lsc_only={lsc_only})')
> >           if color is None:
> > +            logger.warning(f'Ignoring "{f.name}" as it has no associated color temperature')
> >               continue
> 
> 
> Personally I think print the info line after the continue so that a file
> we're ignoring doesn't get both, but either way:
>

Ack. I'll fix that when merging.

Regards,
Stefan


> 
> Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
> 
> >           # Skip lsc image if we don't need it