[PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output

[Kieran Bingham]

Quoting Stefan Klug (2024-07-12 15:32:05)
> Only the first three entries of the matrix were set. Fix that.
> 
> Fixes: cbfdfa42cacc ("ipa: rkisp1: algorithms: Add crosstalk algorithm")
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
>  src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp
> index c1f5403a8ab2..4c4e3f5029a4 100644
> --- a/src/ipa/rkisp1/algorithms/ccm.cpp
> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp
> @@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,
>         float m[9];
>         for (unsigned int i = 0; i < 3; i++) {
>                 for (unsigned int j = 0; j < 3; j++)
> -                       m[i] = frameContext.ccm.ccm[i][j];
> +                       m[i * 3 + j] = frameContext.ccm.ccm[i][j];
>         }

Ooops.

I wonder if we'll ever expose a const data() accessor to just read out
the underlying array. That would imply/expose the knoweledge of the
storage here though, But for now ...

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>         metadata.set(controls::ColourCorrectionMatrix, m);
>  }
> -- 
> 2.43.0
>