[PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output

Paul Elder paul.elder at ideasonboard.com
Fri Jul 19 09:20:55 CEST 2024


On Fri, Jul 12, 2024 at 04:32:05PM +0200, Stefan Klug wrote:
> Only the first three entries of the matrix were set. Fix that.
> 
> Fixes: cbfdfa42cacc ("ipa: rkisp1: algorithms: Add crosstalk algorithm")
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

Oops...

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp
> index c1f5403a8ab2..4c4e3f5029a4 100644
> --- a/src/ipa/rkisp1/algorithms/ccm.cpp
> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp
> @@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,
>  	float m[9];
>  	for (unsigned int i = 0; i < 3; i++) {
>  		for (unsigned int j = 0; j < 3; j++)
> -			m[i] = frameContext.ccm.ccm[i][j];
> +			m[i * 3 + j] = frameContext.ccm.ccm[i][j];
>  	}
>  	metadata.set(controls::ColourCorrectionMatrix, m);
>  }
> -- 
> 2.43.0
> 


More information about the libcamera-devel mailing list