[PATCH 0/6] Raspberry Pi Camera Tuning Tool updates

[David Plowman]

Hi Kieran

Yes, of course. Please add

Signed-off-by: David Plowman <david.plowman at raspberrypi.com>

to all the patches.

Thanks!
David

On Thu, 13 Jun 2024 at 09:29, Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> Quoting Naushir Patuck (2024-06-13 09:16:44)
> > Hi David,
> >
> > Thanks for submitting this.  I have been running with these changes
> > for a while now so
> >
> > Tested-by: Naushir Patuck <naush at raspberrypi.com>
> > Reviewed-by: Naushir Patuck <naush at raspberrypi.com>
> >
>
> Thanks,
>
> David, if you can reply with your Signed-off-by: tag here I can apply it
> to both Ben and Naush's patches...
>
> (I think something like 'git send-email -s' will add this for you on any
> that might have been missed I believe)
>
>
> > Naush
> >
> > On Thu, 6 Jun 2024 at 11:15, David Plowman
> > <david.plowman at raspberrypi.com> wrote:
> > >
> > > Hi everyone
> > >
> > > These 6 patches are a bunch of updates for the Raspberry Pi Camera
> > > Tuning Tool (CTT). Mostly they are adding support for the PiSP
> > > platform (Pi 5) and probably don't interest too many people.
> > >
> > > We could choose to apply all these patches now as they don't affect
> > > anything in libcamera itself, nor the ability to produce vc4 (Pi 4 or
> > > earlier) camera tunings, and then there would be less to apply
> > > later. Otherwise we would wait until all the Pi 5 stuff is in, and
> > > then we could add these.
> > >
> > > I note that they don't pass checkstyle - in fact vast swathes of the
> > > tuning tool don't. I think that may be a job to tackle separately.
>
> Indeed,
>  - https://gitlab.freedesktop.org/camera/libcamera/-/jobs/59751612
>
> I'm fine with that.
>
> Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > >
> > > Thanks!
> > > David
> > >
> > > Ben Benson (2):
> > >   utils: raspberrypi: ctt: Added CAC support to the CTT
> > >   utils: raspberrypi: ctt: Changed CTT handling of VC4 and PiSP
> > >
> > > David Plowman (3):
> > >   utils: raspberrypi: ctt: Adapt tuning tool for both VC4 and PiSP
> > >   utils: raspberrypi: ctt: Update tuning tool for HDR
> > >   utils: raspberrypi: ctt: Add a maximum gain parameter for LSC
> > >
> > > Naushir Patuck (1):
> > >   utils: raspberrypi: ctt: Add option to convert between vc4/pisp
> > >     targets
> > >
> > >  utils/raspberrypi/ctt/alsc_only.py            |  18 +-
> > >  utils/raspberrypi/ctt/cac_only.py             | 142 +++
> > >  utils/raspberrypi/ctt/convert_tuning.py       |  98 ++-
> > >  utils/raspberrypi/ctt/ctt.py                  | 253 +++---
> > >  utils/raspberrypi/ctt/ctt_alsc.py             |  81 +-
> > >  utils/raspberrypi/ctt/ctt_awb.py              |  11 +-
> > >  utils/raspberrypi/ctt/ctt_cac.py              | 228 +++++
> > >  utils/raspberrypi/ctt/ctt_ccm.py              |   6 +-
> > >  utils/raspberrypi/ctt/ctt_config_example.json |   5 +-
> > >  utils/raspberrypi/ctt/ctt_dots_locator.py     | 118 +++
> > >  utils/raspberrypi/ctt/ctt_image_load.py       |   1 +
> > >  utils/raspberrypi/ctt/ctt_pisp.py             | 805 ++++++++++++++++++
> > >  .../raspberrypi/ctt/ctt_pretty_print_json.py  |  22 +-
> > >  utils/raspberrypi/ctt/ctt_tools.py            |   3 +-
> > >  utils/raspberrypi/ctt/ctt_vc4.py              | 126 +++
> > >  15 files changed, 1704 insertions(+), 213 deletions(-)
> > >  create mode 100644 utils/raspberrypi/ctt/cac_only.py
> > >  create mode 100644 utils/raspberrypi/ctt/ctt_cac.py
> > >  create mode 100644 utils/raspberrypi/ctt/ctt_dots_locator.py
> > >  create mode 100755 utils/raspberrypi/ctt/ctt_pisp.py
> > >  create mode 100755 utils/raspberrypi/ctt/ctt_vc4.py
> > >
> > > --
> > > 2.39.2
> > >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20240613/f4d7338d/attachment.htm>