[PATCH 3/3] ipa: rkisp1: agc: Plumb lux

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Fri, Apr 12, 2024 at 06:17:00PM +0900, Paul Elder wrote:
> Now that the rkisp1 IPA has a lux algorithm module, use the lux value
> that comes from that as opposed to hardcoding it.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  src/ipa/rkisp1/algorithms/agc.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
> index ed4d6330..5371ae48 100644
> --- a/src/ipa/rkisp1/algorithms/agc.cpp
> +++ b/src/ipa/rkisp1/algorithms/agc.cpp
> @@ -424,8 +424,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,
>  	double analogueGain = frameContext.sensor.gain;
>  	utils::Duration effectiveExposureValue = exposureTime * analogueGain;
>  
> -	/* \todo Plumb in the lux value. Requires a lux algo + tuning */
> -	double lux = 400;
> +	double lux = frameContext.agc.lux;

I like this :-) But with the current implementation, for this to work, I
think you need to ensure that the Lux algorithm is instantiated in the
tuning file before Agc. This should be documented somewhere.

>  
>  	utils::Duration shutterTime;
>  	double aGain, dGain;

-- 
Regards,

Laurent Pinchart