[PATCH 01/10] libcamera: base: log: Declare log categories when defining them

[Kieran Bingham]

Quoting Laurent Pinchart (2024-06-24 20:29:32)
> libcamera will enable -Wmissing-declarations to catch mismatches between
> function declarations and definitions. There is one offender in log.h:
> when a category is defined with LOG_DEFINE_CATEGORY(), it generates a
> function with no declaration. Fix it by declaring the function using
> LOG_DECLARE_CATEGORY() as the first step fo the category definition.

s/fo/of/
or
s/fo/for/


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  include/libcamera/base/log.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h
> index b5775e491fee..df27df034d79 100644
> --- a/include/libcamera/base/log.h
> +++ b/include/libcamera/base/log.h
> @@ -48,6 +48,7 @@ private:
>  extern const LogCategory &_LOG_CATEGORY(name)();
>  
>  #define LOG_DEFINE_CATEGORY(name)                                      \
> +LOG_DECLARE_CATEGORY(name)                                             \
>  const LogCategory &_LOG_CATEGORY(name)()                               \
>  {                                                                      \
>         /* The instance will be deleted by the Logger destructor. */    \
> -- 
> Regards,
> 
> Laurent Pinchart
>