[PATCH 01/10] libcamera: base: log: Declare log categories when defining them

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jun 24 21:29:32 CEST 2024


libcamera will enable -Wmissing-declarations to catch mismatches between
function declarations and definitions. There is one offender in log.h:
when a category is defined with LOG_DEFINE_CATEGORY(), it generates a
function with no declaration. Fix it by declaring the function using
LOG_DECLARE_CATEGORY() as the first step fo the category definition.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 include/libcamera/base/log.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h
index b5775e491fee..df27df034d79 100644
--- a/include/libcamera/base/log.h
+++ b/include/libcamera/base/log.h
@@ -48,6 +48,7 @@ private:
 extern const LogCategory &_LOG_CATEGORY(name)();
 
 #define LOG_DEFINE_CATEGORY(name)					\
+LOG_DECLARE_CATEGORY(name)						\
 const LogCategory &_LOG_CATEGORY(name)()				\
 {									\
 	/* The instance will be deleted by the Logger destructor. */	\
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list