[PATCH] Revert "meson: Deprecate bitwise operations between different enumeration type"
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue May 7 21:55:50 CEST 2024
Quoting Laurent Pinchart (2024-05-07 19:16:07)
> Enabling -Wdeprecated-enum-enum-conversion by default turned out to be a
> too hasty decision. It causes compilation failures with Qt headers prior
> to Qt v5.15.8. As the previous LTS versions of Debian and Ubuntu ship
> older Qt versions, those errors cause real inconvenience to users.
>
> This reverts commit bf4695266bfca8cc21bcf10a3281e874ebce0d27.
>
> The original goal of avoiding C++20 compilation regressions is still
> handled through a test in CI.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Thanks,
Even my normal local build is broken with bf469526.
This fixes it.
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> meson.build | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 89320adbde1f..39e4947f8c97 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -178,15 +178,6 @@ if cc.has_argument('-Wno-c99-designator')
> ]
> endif
>
> -# Enable the C++20 deprecated enum-enum conversion warning if the compiler
> -# supports it. This helps avoiding C++20 regressions, and should be removed
> -# when switching to C++20 as the warning will then be enabled by default.
> -if cxx.has_argument('-Wdeprecated-enum-enum-conversion')
> - cpp_arguments += [
> - '-Wdeprecated-enum-enum-conversion',
> - ]
> -endif
> -
> c_arguments += common_arguments
> cpp_arguments += common_arguments
>
>
> base-commit: bf4695266bfca8cc21bcf10a3281e874ebce0d27
> --
> Regards,
>
> Laurent Pinchart
>
More information about the libcamera-devel
mailing list