[PATCH v2 5/6] ipa: rpi: Move variables from private to protected

[Naushir Patuck]

On Thu, 9 May 2024 at 12:15, Kieran Bingham <kieran.bingham at ideasonboard.com>
wrote:

> Quoting Naushir Patuck (2024-05-08 09:04:00)
> > The following member variable will be used by the derived IPAs in an
> > upcoming commit, so make them protected:
> >
> > lensPresent_
> > monoSensor_
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
>
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> ;-)
>

I hope to see these duplicated in the merged commit!


>
> > ---
> >  src/ipa/rpi/common/ipa_base.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/ipa/rpi/common/ipa_base.h
> b/src/ipa/rpi/common/ipa_base.h
> > index 512d7e8fe778..ebdc4d297abb 100644
> > --- a/src/ipa/rpi/common/ipa_base.h
> > +++ b/src/ipa/rpi/common/ipa_base.h
> > @@ -71,6 +71,9 @@ protected:
> >         /* Whether the stitch block (if available) needs to swap
> buffers. */
> >         bool stitchSwapBuffers_;
> >
> > +       bool monoSensor_;
> > +       bool lensPresent_;
> > +
> >  private:
> >         /* Number of metadata objects available in the context list. */
> >         static constexpr unsigned int numMetadataContexts = 16;
> > @@ -96,9 +99,6 @@ private:
> >
> >         std::map<unsigned int, MappedFrameBuffer> buffers_;
> >
> > -       bool lensPresent_;
> > -       bool monoSensor_;
> > -
> >         std::array<RPiController::Metadata, numMetadataContexts>
> rpiMetadata_;
> >
> >         /*
> > --
> > 2.34.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20240509/84aa4c48/attachment.htm>